On Mon, Apr 27, 2009 at 15:09, Ralf Baechle <email@example.com> wrote:
> On Mon, Apr 27, 2009 at 06:59:17AM -0600, Shane McDonald wrote:
>> There have been a number of compile problems with the msp71xx
>> configuration ever since it was included in the linux-mips.org
>> repository. This patch resolves these problems:
>> - proper files are included when using a squashfs rootfs
>> - resetting the board no longer uses non-existent GPIO routines
>> - create the required plat_timer_setup function
>> This patch has been compile-tested against the current HEAD.
>> Signed-off-by: Shane McDonald <firstname.lastname@example.org>
>> arch/mips/pmc-sierra/msp71xx/msp_prom.c | 3 ++-
>> arch/mips/pmc-sierra/msp71xx/msp_setup.c | 8 ++------
>> arch/mips/pmc-sierra/msp71xx/msp_time.c | 7 ++-----
>> 3 files changed, 6 insertions(+), 12 deletions(-)
>> diff --git a/arch/mips/pmc-sierra/msp71xx/msp_prom.c
>> index e5bd548..1e2d984 100644
>> --- a/arch/mips/pmc-sierra/msp71xx/msp_prom.c
>> +++ b/arch/mips/pmc-sierra/msp71xx/msp_prom.c
>> @@ -44,7 +44,8 @@
>> #include <linux/cramfs_fs.h>
>> #ifdef CONFIG_SQUASHFS
>> -#include <linux/squashfs_fs.h>
>> +#include <linux/magic.h>
>> +#include "../../../../fs/squashfs/squashfs_fs.h"
> No way. You're reaching deep into the internals of squashfs for no good
> reason. The only use of anything from squashfs_fs.h is a cast and casting
> to void * would work just as well.
He needs the definition of struct squashfs_super_block to access the .bytes_used
field. Alternatively, the offset of that field must be hardcoded.
BTW, the magic is __le32, and bytes_used is __le64, so there are some
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- email@example.com
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds