[Top] [All Lists]

Re: [MIPS] Resolve compile issues with msp71xx configuration

To: Shane McDonald <>
Subject: Re: [MIPS] Resolve compile issues with msp71xx configuration
From: Sergei Shtylyov <>
Date: Mon, 27 Apr 2009 17:18:08 +0400
Cc: Ralf Baechle <>,
In-reply-to: <>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;
References: <E1LyQQX-00047N-6E@localhost> <>
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803

Ralf Baechle wrote:

There have been a number of compile problems with the msp71xx
configuration ever since it was included in the
repository.  This patch resolves these problems:
- proper files are included when using a squashfs rootfs
- resetting the board no longer uses non-existent GPIO routines
- create the required plat_timer_setup function

   get_c0_compare_int(), you mean?

This patch has been compile-tested against the current HEAD.

Signed-off-by: Shane McDonald <>

diff --git a/arch/mips/pmc-sierra/msp71xx/msp_setup.c 
index c936756..a54e85b 100644
--- a/arch/mips/pmc-sierra/msp71xx/msp_setup.c
+++ b/arch/mips/pmc-sierra/msp71xx/msp_setup.c
@@ -21,7 +21,6 @@

#if defined(CONFIG_PMC_MSP7120_GW)
#include <msp_regops.h>
-#include <msp_gpio.h>

@@ -88,11 +87,8 @@ void msp7120_reset(void)
         * as GPIO char driver may not be enabled and it would look up
         * data inRAM!
-       set_value_reg32(GPIO_CFG3_REG,
-                       basic_mode_mask(MSP_BOARD_RESET_GPIO),
-                       basic_mode(MSP_GPIO_OUTPUT, MSP_BOARD_RESET_GPIO));
-       set_reg32(GPIO_DATA3_REG,
-                       basic_data_mask(MSP_BOARD_RESET_GPIO));
+       set_value_reg32(GPIO_CFG3_REG, 0xf000, 0x8000);
+       set_reg32(GPIO_DATA3_REG, 8);

         * In case GPIO9 doesn't reset the board (jumper configurable!)
diff --git a/arch/mips/pmc-sierra/msp71xx/msp_time.c 
index 7cfeda5..cca64e1 100644
--- a/arch/mips/pmc-sierra/msp71xx/msp_time.c
+++ b/arch/mips/pmc-sierra/msp71xx/msp_time.c
@@ -81,10 +81,7 @@ void __init plat_time_init(void)
        mips_hpt_frequency = cpu_rate/2;

-void __init plat_timer_setup(struct irqaction *irq)
+unsigned int __init get_c0_compare_int(void)
-       /* we are using the vpe0 counter for timer interrupts */
-       setup_irq(MSP_INT_VPE0_TIMER, irq);
+       return MSP_INT_VPE0_TIMER;

The rest seems ok.  Can you fix the issue above and send a new patch?

   Better yet 3 patches as the 3 issues seem totally unrelated.



WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>