linux-mips
[Top] [All Lists]

Re: [PATCH] DMA: TXx9 Soc DMA Controller driver (v3)

To: dan.j.williams@intel.com
Subject: Re: [PATCH] DMA: TXx9 Soc DMA Controller driver (v3)
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Sat, 25 Apr 2009 02:12:46 +0900 (JST)
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <e9c3a7c20904240749g79b7b54cufa64149e44b5753a@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1240414831-20429-1-git-send-email-anemo@mba.ocn.ne.jp> <e9c3a7c20904240749g79b7b54cufa64149e44b5753a@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 24 Apr 2009 07:49:10 -0700, Dan Williams <dan.j.williams@intel.com> 
wrote:
> > +       /*
> > +        * We use dma_unmap_page() regardless of how the buffers were
> > +        * mapped before they were submitted...
> > +        */
> 
> This will be caught by the new dma-mapping debug infrastructure that
> went in for 2.6.30, but I would not hold up merging this driver for
> this issue.  Once Maciej's fix [1] goes upstream you can fix up your
> driver to use the new "unmap single" flags.

OK, I will follow that when the flag is merged.  Thanks.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>