linux-mips
[Top] [All Lists]

Re: [PATCH] DMA: TXx9 Soc DMA Controller driver (v3)

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] DMA: TXx9 Soc DMA Controller driver (v3)
From: Dan Williams <dan.j.williams@intel.com>
Date: Fri, 24 Apr 2009 07:49:10 -0700
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, linux-kernel@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=pMDyAah7gAA5TW/9kZ/3zTVUHfmt7lhJPqzzCDmLkPk=; b=f9tQ58moGd5ru8eINQ5FFVI4Uo4mH4YiSLbgtJmHyX/PKauENj+/uIoPM+6So/PV4a jAf9qIlWNxUEa+EM84Mq9q+4vIi9KenABh6FFk1m6pHBbX2J7tmsbvBMCiLgjUxNJbnx KUgH39zKjCCvfifRcy7eVnxQa+qYulKKqbAHE=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=dG3uyWsLTz7unwWZyt/c/7Ssw96m7xkKVsOsC1vUZmQNytl7TxM7h0aPYdC9efqH4s hL+loprQ+ZiYiDH1KQu9oG/2mB+Ppg+tTpY3VVRmBZs2Lno6zDjNb/FXGp8VYC8ClVSH D16+Vng/3CZw1nJ43Qd3FfeDkxIXPOhAtej2E=
In-reply-to: <1240414831-20429-1-git-send-email-anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1240414831-20429-1-git-send-email-anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
On Wed, Apr 22, 2009 at 8:40 AM, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> This patch adds support for the integrated DMAC of the TXx9 family.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

Acked-by: Dan Williams <dan.j.williams@intel.com>

> +static void
> +txx9dmac_descriptor_complete(struct txx9dmac_chan *dc,
> +                            struct txx9dmac_desc *desc)
[..]
> +       /*
> +        * We use dma_unmap_page() regardless of how the buffers were
> +        * mapped before they were submitted...
> +        */

This will be caught by the new dma-mapping debug infrastructure that
went in for 2.6.30, but I would not hold up merging this driver for
this issue.  Once Maciej's fix [1] goes upstream you can fix up your
driver to use the new "unmap single" flags.

Thanks,
Dan

[1]: http://marc.info/?l=linux-kernel&m=124049040806961&w=2

<Prev in Thread] Current Thread [Next in Thread>