linux-mips
[Top] [All Lists]

Re: [PATCH] Clean up Lemote Loongson 2E Support

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] Clean up Lemote Loongson 2E Support
From: Philippe Vachon <philippe@cowpig.ca>
Date: Wed, 22 Apr 2009 02:19:39 -0400
Cc: linux-mips@linux-mips.org
In-reply-to: <20090422060951.GA12850@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20090422055809.GA1821@cowpig.ca> <20090422060951.GA12850@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.9i
On Wed, Apr 22, 2009 at 08:09:51AM +0200, Ralf Baechle wrote:
> > +static inline void ls2e_writeb(uint8_t value, phys_addr_t addr)
> > +{
> > +   *(volatile uint8_t *)addr = value;
> 
> So is addr a physical addres or a virtual one?  In the first case you
> can't dereference it, in the latter the type is wrong.
> 
Aha, you caught me. That should be 'unsigned long' as opposed to
phys_addr_t, as the address is a virtual address.

P.

<Prev in Thread] Current Thread [Next in Thread>