Re: [PATCH] Clean up Lemote Loongson 2E Support

[Philippe Vachon <philippe@cowpig.ca>]

On Wed, Apr 22, 2009 at 08:09:51AM +0200, Ralf Baechle wrote:
> > +static inline void ls2e_writeb(uint8_t value, phys_addr_t addr)
> > +{
> > +   *(volatile uint8_t *)addr = value;
> 
> So is addr a physical addres or a virtual one?  In the first case you
> can't dereference it, in the latter the type is wrong.
> 
Aha, you caught me. That should be 'unsigned long' as opposed to
phys_addr_t, as the address is a virtual address.

P.