| To: | Philippe Vachon <philippe@cowpig.ca> |
|---|---|
| Subject: | Re: [PATCH] Clean up Lemote Loongson 2E Support |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Wed, 22 Apr 2009 08:09:51 +0200 |
| Cc: | linux-mips@linux-mips.org |
| In-reply-to: | <20090422055809.GA1821@cowpig.ca> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20090422055809.GA1821@cowpig.ca> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Wed, Apr 22, 2009 at 01:58:09AM -0400, Philippe Vachon wrote:
> +static inline void ls2e_writeb(uint8_t value, phys_addr_t addr)
> +{
> + *(volatile uint8_t *)addr = value;
So is addr a physical addres or a virtual one? In the first case you
can't dereference it, in the latter the type is wrong.
Ralf
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] Alchemy: time.c build fix, Manuel Lauss |
|---|---|
| Next by Date: | Re: [PATCH] Clean up Lemote Loongson 2E Support, Philippe Vachon |
| Previous by Thread: | [PATCH] Clean up Lemote Loongson 2E Support, Philippe Vachon |
| Next by Thread: | Re: [PATCH] Clean up Lemote Loongson 2E Support, Philippe Vachon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |