linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Include linux/errno.h from arch/mips/include/asm/compa

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, ralf@linux-mips.org
Subject: Re: [PATCH] MIPS: Include linux/errno.h from arch/mips/include/asm/compat.h
From: David Daney <ddaney@caviumnetworks.com>
Date: Thu, 16 Apr 2009 09:02:00 -0700
Cc: linux-mips@linux-mips.org
In-reply-to: <20090411.233150.25909696.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1239388895-27305-1-git-send-email-ddaney@caviumnetworks.com> <20090410191611.GB23582@linux-mips.org> <20090411.233150.25909696.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Atsushi Nemoto wrote:
On Fri, 10 Apr 2009 12:16:11 -0700, Ralf Baechle <ralf@linux-mips.org> wrote:
On Fri, Apr 10, 2009 at 11:41:35AM -0700, David Daney wrote:

The recent change that added #include <linux/seccomp.h> breaks
(because EINVAL is not defined) when building
arch/mips/kernel/asm-offsets.s if CONFIG_SECCOMP is not defined.
Including errno.h fixes the problem.
NAK, <linux/seccomp.h> should include <linux/errno.h>.

Then how about this?

------------------------------------------------------
Subject: [PATCH] Do not include seccomp.h from compat.h
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

The compat.h does not need seccomp.h since TIF_32BIT was moved to
thread_info.h

This fixes a build error of 64-bit kernel without CONFIG_SECCOMP.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

Signed-off-by: David Daney <ddaney@caviumnetworks.com>

---
 arch/mips/include/asm/compat.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/mips/include/asm/compat.h b/arch/mips/include/asm/compat.h
index 6c5b409..f58aed3 100644
--- a/arch/mips/include/asm/compat.h
+++ b/arch/mips/include/asm/compat.h
@@ -3,7 +3,6 @@
 /*
  * Architecture specific compatibility types
  */
-#include <linux/seccomp.h>
 #include <linux/thread_info.h>
 #include <linux/types.h>
 #include <asm/page.h>




<Prev in Thread] Current Thread [Next in Thread>