| To: | yanhua <yanh@lemote.com> |
|---|---|
| Subject: | Re: [PATCH 10/14] lemote: rtc driver binary mode support |
| From: | Zhang Le <r0bertz@gentoo.org> |
| Date: | Mon, 13 Apr 2009 18:48:17 +0800 |
| Cc: | linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, 彭亮锦 <penglj@lemote.com>, "zhangfx@lemote.com" <zhangfx@lemote.com> |
| In-reply-to: | <49DD8238.7060609@lemote.com> |
| Mail-followup-to: | yanhua <yanh@lemote.com>, linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, 彭亮锦 <penglj@lemote.com>, "zhangfx@lemote.com" <zhangfx@lemote.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <49DD8238.7060609@lemote.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
On 13:06 Thu 09 Apr , yanhua wrote:
> if (is_valid_irq(rtc_irq) &&
> - (!(rtc_control & RTC_24H) || (rtc_control & (RTC_DM_BINARY)))) {
> + (!(rtc_control & RTC_24H) /*|| (rtc_control & (RTC_DM_BINARY))*/)) {
Why not just remove this part "/*|| (rtc_control & (RTC_DM_BINARY))*/" ?
> dev_dbg(dev, "only 24-hr BCD mode supported\n");
> retval = -ENXIO;
> goto cleanup1;
Zhang, Le
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] MIPS: Include linux/errno.h from arch/mips/include/asm/compat.h, Atsushi Nemoto |
|---|---|
| Next by Date: | Re: [PATCH 1/14] lemote: Loongson2F based machines support, Zhang Le |
| Previous by Thread: | Re: [PATCH 10/14] lemote: rtc driver binary mode support, Sergei Shtylyov |
| Next by Thread: | [PATCH 11/14] lemote: Hibernation Support in mips system, yanhua |
| Indexes: | [Date] [Thread] [Top] [All Lists] |