linux-mips
[Top] [All Lists]

Re: [PATCH 1/14] lemote: Loongson2F based machines support

To: yanhua <yanh@lemote.com>
Subject: Re: [PATCH 1/14] lemote: Loongson2F based machines support
From: Arnaud Patard <apatard@mandriva.com>
Date: Thu, 09 Apr 2009 10:39:26 +0200
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, 彭亮锦 <penglj@lemote.com>, "zhangfx@lemote.com" <zhangfx@lemote.com>
In-reply-to: <49DD7E88.7040305@lemote.com> (yanhua's message of "Thu, 09 Apr 2009 12:50:16 +0800")
Organization: Mandriva
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <49DD7E88.7040305@lemote.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.1 (gnu/linux)
yanhua <yanh@lemote.com> writes:

Hi,


> Mini fuloong, yeeloong are all Loongson2F based systems. Loongson2F have
> builtin DDR2 and PCIX controller. The PCIX controller have a similar
> programming interface with FPGA northbridge used in Loongson2E.

First, please read Documentation/SubmittingPatches first. There's no
signed-off-by and this patch is too big. So big patches are making
review a nightmare, please split it into smaller pieces :(

Also, I'd like to see a different directories layout. You're doing :
arch/mips/lemote/
    lm2e/
    lm2f/
        common/
        fuloong/
        yeeloong/

This is quite annoying because:
- I'll prefer seeing loongson instead of Lemote. I've some ST machines
  here they do share a lot of code with the 2e/2f so I'd like to avoid
  duplicating code.

- There's some code very similar between 2e, 2f-yeelong and
  2f-fuloong and other machines. Why not putting them in a common
  directory instead of duplicating again some code ?

To sum up, imho, it would be better to have something like :
arch/mips/loongson/
    common/
    2e/
    2f/ (or something similar)
       common/
       yeelong/
       fuloong/
       ...

Arnaud

<Prev in Thread] Current Thread [Next in Thread>