linux-mips
[Top] [All Lists]

Re: [PATCH] added Loongson cpu-feature-overrides.h

To: linux-mips@linux-mips.org
Subject: Re: [PATCH] added Loongson cpu-feature-overrides.h
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 2 Apr 2009 13:47:46 +0200
In-reply-to: <20090402112739.GD28319@adriano.hkcable.com.hk>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1238658105-23260-1-git-send-email-r0bertz@gentoo.org> <20090402111607.GB1678@linux-mips.org> <20090402112739.GD28319@adriano.hkcable.com.hk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Apr 02, 2009 at 07:27:39PM +0800, Zhang Le wrote:

> > > I have taken Wu Zhangjin's and Philippe Vachon's version as references, 
> > > did a
> > > little modification and tested on 16K page size kernel. It works well.
> > > 
> > > Unfornately although it already has defined cpu_has_dc_aliases as 1, 4k 
> > > page
> > > size still not working. More work needed here.
> > 
> > Adding this file is only a matter of kernel optimization.  You may have
> > saved as much as several hundred kb!  But it won't get a kernel
> > that wasn't working before to work.  If anything the opposite ...
> 
> I see. Thanks.
> BTW, I have just made another little change:
> 
> #define cpu_has_dc_aliases      (PAGE_SIZE < 0x4000)
> 
> Since waysize is 16k.
> 
> Anyway, it is good to include this file now, or postpone it a little later?
> If yes, then I will send a new version soon.

Correct - but this alone doesn't get all 4k or 64k pages to work so how
about we deal with this one later?

  Ralf

<Prev in Thread] Current Thread [Next in Thread>