linux-mips
[Top] [All Lists]

Re: [PATCH] added Loongson cpu-feature-overrides.h

To: linux-mips@linux-mips.org, wuzj@lemote.com
Subject: Re: [PATCH] added Loongson cpu-feature-overrides.h
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 2 Apr 2009 13:13:12 +0200
In-reply-to: <20090402105613.GC28319@adriano.hkcable.com.hk>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1238658105-23260-1-git-send-email-r0bertz@gentoo.org> <20090402105613.GC28319@adriano.hkcable.com.hk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Apr 02, 2009 at 06:56:13PM +0800, Zhang Le wrote:

> On 15:41 Thu 02 Apr     , Zhang Le wrote:
> > diff --git a/arch/mips/include/asm/mach-lemote/cpu-feature-overrides.h 
> > b/arch/mips/include/asm/mach-lemote/cpu-feature-overrides.h
> > new file mode 100644
> > index 0000000..550a10d
> > --- /dev/null
> > +++ b/arch/mips/include/asm/mach-lemote/cpu-feature-overrides.h
> 
> [snip]
> 
> > +#define cpu_icache_snoops_remote_store     1
> 
> This maybe should not exist here, since this only matters on SMP.
> It exists in Wu's version. Maybe Wu could explain it. Maybe it is just a typo.
> 
> Pulling him in.

This simply doesn't matter on a uniprocessor system.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>