linux-mips
[Top] [All Lists]

Re: [PATCH] au1xxx-ide: fix build with CONFIG_PM

To: Manuel Lauss <mano@roarinelk.homelinux.net>
Subject: Re: [PATCH] au1xxx-ide: fix build with CONFIG_PM
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Tue, 31 Mar 2009 21:00:39 +0400
Cc: Linux-MIPS <linux-mips@linux-mips.org>
In-reply-to: <1238517876-4724-1-git-send-email-mano@roarinelk.homelinux.net>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1238517876-4724-1-git-send-email-mano@roarinelk.homelinux.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
Hello.

Manuel Lauss wrote:

au1xxx_ide_dev_t is never defined;  get rid of all PM stuff as

   You meant au1xxx_power_dev_t?

well since it is not in the driver source anyway.

Signed-off-by: Manuel Lauss <mano@roarinelk.homelinux.net>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

diff --git a/arch/mips/include/asm/mach-au1x00/au1xxx_ide.h 
b/arch/mips/include/asm/mach-au1x00/au1xxx_ide.h
index 60638b8..5656c72 100644
--- a/arch/mips/include/asm/mach-au1x00/au1xxx_ide.h
+++ b/arch/mips/include/asm/mach-au1x00/au1xxx_ide.h
@@ -46,20 +46,6 @@
 #define CONFIG_BLK_DEV_IDE_AU1XXX_BURSTABLE_ON 0
 #endif
-#ifdef CONFIG_PM
-/*
- * This will enable the device to be powered up when write() or read()
- * is called. If this is not defined, the driver will return -EBUSY.
- */
-#define WAKE_ON_ACCESS 1
-
-typedef struct {
-       spinlock_t              lock;   /* Used to block on state transitions */
-       au1xxx_power_dev_t      *dev;   /* Power Managers device structure */
-       unsigned                stopped; /* Used to signal device is stopped */
-} pm_state;
-#endif
-
 typedef struct {
        u32                     tx_dev_id, rx_dev_id, target_dev_id;
        u32                     tx_chan, rx_chan;
@@ -72,9 +58,6 @@ typedef struct {
 #endif
        int                     irq;
        u32                     regbase;
-#ifdef CONFIG_PM
-       pm_state                pm;
-#endif
 } _auide_hwif;
/******************************************************************************/

MBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>