linux-mips
[Top] [All Lists]

Re: [PATCH 1/3] Alchemy: get rid of common/platform.c

To: Manuel Lauss <mano@roarinelk.homelinux.net>
Subject: Re: [PATCH 1/3] Alchemy: get rid of common/platform.c
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Sun, 29 Mar 2009 15:37:05 +0400
Cc: Linux-MIPS <linux-mips@linux-mips.org>
In-reply-to: <1238318822-4772-2-git-send-email-mano@roarinelk.homelinux.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1238318822-4772-1-git-send-email-mano@roarinelk.homelinux.net> <1238318822-4772-2-git-send-email-mano@roarinelk.homelinux.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.21 (Windows/20090302)
Hello.

Manuel Lauss wrote:
Move device registration out of common/platform.c into the individual
boards' platform.c files.

Every board should register the devices it wants to use (i.e. on one
of my Au1200 systems UART1 is unused [pinmux problems] and its
functionality is provided by an external device.  This also results
in a completely useless ttyS1 entry; I want this entry gone without
having to add a lot more #ifdef <platform> lines to common/platform.c).

No #ifdef's would be needed at all if you check what devices are enabled before registering.

Signed-off-by: Manuel Lauss <mano@roarinelk.homelinux.net>

  NAK.

WBR. Sergei



<Prev in Thread] Current Thread [Next in Thread>