linux-mips
[Top] [All Lists]

Re: [PATCH 0/3] Alchemy: platform updates

To: Manuel Lauss <mano@roarinelk.homelinux.net>
Subject: Re: [PATCH 0/3] Alchemy: platform updates
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Sun, 29 Mar 2009 15:35:02 +0400
Cc: Linux-MIPS <linux-mips@linux-mips.org>
In-reply-to: <1238318822-4772-1-git-send-email-mano@roarinelk.homelinux.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1238318822-4772-1-git-send-email-mano@roarinelk.homelinux.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.21 (Windows/20090302)
Hello.

Manuel Lauss wrote:

Patch overview:

#1: eliminate alchemy/common/platform.c.  Add platform device
    registration to all boards instead.

I'm strongly voting against this, as it causes totally unneeded code duplication. Please don't apply.

    I realize this is a lot of (needless) code duplication at first,
    but it seems a lot cleaner to me if each board registered the
    devices it needs/wants.

No, it's certainly a step backwards. You could make the common code more flexible by checking what devices are enabled and registering them selectively as I have already suggested several months ago. That would be the clean solution unlike your code bloat.

WBR, Sergei



<Prev in Thread] Current Thread [Next in Thread>