|To:||Manuel Lauss <firstname.lastname@example.org>|
|Subject:||Re: [PATCH 0/3] Alchemy: platform updates|
|From:||Sergei Shtylyov <email@example.com>|
|Date:||Sun, 29 Mar 2009 15:35:02 +0400|
|User-agent:||Thunderbird 188.8.131.52 (Windows/20090302)|
Hello. Manuel Lauss wrote:
Patch overview: #1: eliminate alchemy/common/platform.c. Add platform device registration to all boards instead.
I'm strongly voting against this, as it causes totally unneeded code duplication. Please don't apply.
I realize this is a lot of (needless) code duplication at first, but it seems a lot cleaner to me if each board registered the devices it needs/wants.
No, it's certainly a step backwards. You could make the common code more flexible by checking what devices are enabled and registering them selectively as I have already suggested several months ago. That would be the clean solution unlike your code bloat.
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: [PATCH 5/6] Alchemy: don't unconditionally register all alchemy platform devices, Sergei Shtylyov|
|Next by Date:||Re: [PATCH 1/3] Alchemy: get rid of common/platform.c, Sergei Shtylyov|
|Previous by Thread:||Re: [PATCH 1/3] Alchemy: get rid of common/platform.c, Sergei Shtylyov|
|Next by Thread:||Re: [PATCH 0/3] Alchemy: platform updates, Manuel Lauss|
|Indexes:||[Date] [Thread] [Top] [All Lists]|