linux-mips
[Top] [All Lists]

Re: [PATCH 0/6] Alchemy updates for 2.6.30

To: Manuel Lauss <mano@roarinelk.homelinux.net>
Subject: Re: [PATCH 0/6] Alchemy updates for 2.6.30
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Sun, 29 Mar 2009 15:02:21 +0400
Cc: Linux-MIPS <linux-mips@linux-mips.org>
In-reply-to: <1237999773-5174-1-git-send-email-mano@roarinelk.homelinux.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1237999773-5174-1-git-send-email-mano@roarinelk.homelinux.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.21 (Windows/20090302)
Hello.

Manuel Lauss wrote:

Here is another set of patches which aim to improve Alchemy and DB1200 support.
(doesn't apply against Kevin Hickey's DB1300 patches)

[...]

#5    I dislike the alchemy/common/platform.c file because it makes passing
      platform data to drivers ugly (the platdata struct and the consumer
      are in different files)

I think it's rather smart scheme -- prevents duplication. Please don't change it.

 and I also don't like the fact that every conceivable piece of alchemy 
hardware has a driver registered whether I like it or not.

Only platform device, not the driver. User entirely controls what drivers are built.

To not change existing behaviour, the platform.c file is now invoked by the 
board Makefiles instead of the one in common/.

WBR, Sergei



<Prev in Thread] Current Thread [Next in Thread>