linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] dmaengine: TXx9 Soc DMA Controller driver

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH 1/2] dmaengine: TXx9 Soc DMA Controller driver
From: Dan Williams <dan.j.williams@intel.com>
Date: Tue, 17 Mar 2009 18:23:46 -0700
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, linux-kernel@vger.kernel.org, haavard.skinnemoen@atmel.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=q+UUpo1M3Pk8FcE8+NLeOArNUlMO+QfeBw4F84KMbJE=; b=JVwML4bJzEjP+Mm8fOYZ1IeT4q7qw+b+4Jx2JVAbpFxwBaGDZmgILSte+C3E4VA3kF /FRNdm5AmamaPW6CAZe3qeuha7yczM2luybbHnUglTVAwoS7c8iqDmT9eCQ0B8Ozg18S i1ZpddrnjpYcEXZWc30MCuNUP8CPCPFy8nOcQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=CH9mMjHavDdvxhVHtYjdx+ZUy3xBxKnq64nXM1hgSET19K8scRfyit0iP43gfswgW0 7JukRp37rZ+CM9UtL1kpgC24vl1S3QEV3s0q6hiU2gO5Kon+CntCvfA8/MM3ik+5x+TV DyabHlt/lmiM2k55wjDXiBmzkDxMBXNQlCrKw=
In-reply-to: <20090318.094935.238694196.nemoto@toshiba-tops.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <e9c3a7c20903162152w6b73b4b8hba8004e7b349c447@mail.gmail.com> <20090318.010939.128619068.anemo@mba.ocn.ne.jp> <e9c3a7c20903171002n50964148v8366fa2f00e3164c@mail.gmail.com> <20090318.094935.238694196.nemoto@toshiba-tops.co.jp>
Sender: linux-mips-bounce@linux-mips.org
On Tue, Mar 17, 2009 at 5:49 PM, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> On Tue, 17 Mar 2009 10:02:14 -0700, Dan Williams <dan.j.williams@intel.com> 
> wrote:
> BTW, there are another holes in dma_async_device_register.  If
> idr_pre_get or idr_get_new was failed, idr_ref will not be freed.

Thanks for these fixlets, I appreciate it.

Now, back to the issue at hand.  Does your driver still need direct
control over chan->chan_id, or can it now rely on the fact that
dma_async_device_register() will fail if a channel is not initialized?
 Or, just use some platform_data to identify the channel in the same
manner as atmel-mci?

Regards,
Dan

<Prev in Thread] Current Thread [Next in Thread>