linux-mips
[Top] [All Lists]

Re: [PATCH] oprofile: VR5500 performance counter driver

To: "M. Asselstine" <Mark.Asselstine@windriver.com>
Subject: Re: [PATCH] oprofile: VR5500 performance counter driver
From: Robert Richter <robert.richter@amd.com>
Date: Thu, 26 Feb 2009 18:07:25 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, oprofile-list@lists.sf.net
In-reply-to: <200902261130.48307.Mark.Asselstine@windriver.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1235406394-2650-1-git-send-email-mark.asselstine@windriver.com> <20090225165953.GF25042@erda.amd.com> <200902261130.48307.Mark.Asselstine@windriver.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.16 (2007-06-09)
Thanks Mark.

On 26.02.09 11:30:48, M. Asselstine wrote:
> > > + if (cpu_has_mips_r2 && !(read_c0_cause() & (1 << 26)))
> >
> > Do not use magic numbers.
> >
> 
> A comment will be added or a well named define.

I found this:

 arch/mips/include/asm/mipsregs.h:#define  CAUSEB_CE            28

Not sure if this is the same register. If so, you could add the macro
to mipsregs.h too.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com


<Prev in Thread] Current Thread [Next in Thread>