linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: rb532: remove useless CF GPIO initialisation

To: Phil Sutter <n0-1@freewrt.org>
Subject: Re: [PATCH] MIPS: rb532: remove useless CF GPIO initialisation
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 29 Jan 2009 16:47:27 +0000
Cc: linux-mips@linux-mips.org
In-reply-to: <20081128194346.5A883386DBBE@mail.ifyouseekate.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20081128193322.D103C386DBBE@mail.ifyouseekate.net> <20081128194346.5A883386DBBE@mail.ifyouseekate.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Nov 28, 2008 at 08:46:22PM +0100, Phil Sutter wrote:

> As the pata-rb532-cf driver calls gpio_set_direction_input(), the calls
> to rb532_gpio_set_func() and rb532_gpio_direction_input() are not needed
> since the alternate function is automatically being disabled when
> changing the GPIO pin direction.
> The later two calls to rb532_gpio_set_{ilevel,istat}() are implicitly
> being done by the IRQ initialisation of pata-rb532-cf.
> 
> Signed-off-by: Phil Sutter <n0-1@freewrt.org>

Applied.  Thanks!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] MIPS: rb532: remove useless CF GPIO initialisation, Ralf Baechle <=