linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: rb532: add set_type() function to IRQ struct

To: Phil Sutter <n0-1@freewrt.org>
Subject: Re: [PATCH] MIPS: rb532: add set_type() function to IRQ struct
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 29 Jan 2009 16:39:56 +0000
Cc: linux-mips@linux-mips.org
In-reply-to: <20081128194234.EC0FC386DBBE@mail.ifyouseekate.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20081128193322.D103C386DBBE@mail.ifyouseekate.net> <20081128194234.EC0FC386DBBE@mail.ifyouseekate.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Nov 28, 2008 at 08:45:10PM +0100, Phil Sutter wrote:

> +     switch (type) {
> +             case IRQ_TYPE_LEVEL_HIGH:
> +                     rb532_gpio_set_ilevel(1, gpio);
> +                     break;
> +             case IRQ_TYPE_LEVEL_LOW:
> +                     rb532_gpio_set_ilevel(0, gpio);
> +                     break;
> +             default:
> +                     return -EINVAL;
> +     }

Linux coding style - the case and default labels should have the same
indentation level as the switch statement.  I fixed that.

Applied, thanks.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] MIPS: rb532: add set_type() function to IRQ struct, Ralf Baechle <=