Re: [PATCH][MIPS] add return value check to user_termio_to_kernel

linux-mips

Re: [PATCH][MIPS] add return value check to user_termio_to_kernel_termio

To:	Ralf Baechle <ralf@linux-mips.org>
Subject:	Re: [PATCH][MIPS] add return value check to user_termio_to_kernel_termios()
From:	Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Date:	Thu, 29 Jan 2009 21:00:56 +0900
Cc:	yoichi_yuasa@tripeaks.co.jp, linux-mips <linux-mips@linux-mips.org>
In-reply-to:	<20090128134007.GA29709@linux-mips.org>
Organization:	TriPeaks Corporation
Original-recipient:	rfc822;linux-mips@linux-mips.org
References:	<20090125224557.8582051b.yoichi_yuasa@tripeaks.co.jp> <20090128124047.GA25706@linux-mips.org> <20090128134007.GA29709@linux-mips.org>
Sender:	linux-mips-bounce@linux-mips.org

Hi,

On Wed, 28 Jan 2009 13:40:07 +0000
Ralf Baechle <ralf@linux-mips.org> wrote:

> On Wed, Jan 28, 2009 at 12:40:47PM +0000, Ralf Baechle wrote:
> 
> > Duh...  That sort of trivial thing is not fatal but just shouldn't
> > happen.  And other architectures have the same bug even.  Your patch
> > leaves the last get_user and the copy_from_user return values unchecked.
> > I'll sort that out.
> 
> How about this patch which also gets rid of the rest of the macro soup
> by replacing them with inline functions.
> 
> How about this?

It's good for me.

Yoichi

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH][MIPS] add return value check to user_termio_to_kernel_termios(), Yoichi Yuasa Re: [PATCH][MIPS] add return value check to user_termio_to_kernel_termios(), Ralf Baechle Re: [PATCH][MIPS] add return value check to user_termio_to_kernel_termios(), Ralf Baechle Re: [PATCH][MIPS] add return value check to user_termio_to_kernel_termios(), Yoichi Yuasa <=

Previous by Date:	Re: [PATCH] MIPS: Use hardware watchpoints on all R1 and R2 CPUs., Ralf Baechle
Next by Date:	Re: memcpy and prefetch, Atsushi Nemoto
Previous by Thread:	Re: [PATCH][MIPS] add return value check to user_termio_to_kernel_termios(), Ralf Baechle
Next by Thread:	AU1550 Kernel bug detected[#1] clockevents_register_device, Frank Neuber
Indexes:	[Date] [Thread] [Top] [All Lists]