linux-mips
[Top] [All Lists]

Re: [PATCH] au1000: convert to using gpiolib

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH] au1000: convert to using gpiolib
From: Manuel Lauss <mano@roarinelk.homelinux.net>
Date: Tue, 27 Jan 2009 11:11:12 +0100
Cc: ralf@linux-mips.org, Linux-MIPS <linux-mips@linux-mips.org>
In-reply-to: <200901271102.37230.florian@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200901151646.49591.florian@openwrt.org> <200901271039.31680.florian@openwrt.org> <20090127094716.GA16179@roarinelk.homelinux.net> <200901271102.37230.florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.16 (2007-06-09)
On Tue, Jan 27, 2009 at 11:02:36AM +0100, Florian Fainelli wrote:
> Le Tuesday 27 January 2009 10:47:16 Manuel Lauss, vous avez ?crit?:
> > On Tue, Jan 27, 2009 at 10:39:30AM +0100, Florian Fainelli wrote:
> > > Le Tuesday 27 January 2009 07:58:27 Manuel Lauss, vous avez ?crit?:
> > > > Florian,
> > > >
> > > > > Le Monday 19 January 2009 18:12:23 Florian Fainelli, vous avez ?crit?:
> > > > > > This patch converts the GPIO board code to use gpiolib.
> > > > > > Changes from v1:
> > > > > > - allow users not to use the default gpio accessors
> > > > > > - do not lock au1000_gpio2_set
> > > > >
> > > > > I did not receive comments from you on this patch, can I consider it
> > > > > being ok ?
> > > >
> > > > Oh sorry.  Please export all the au1000_gpioX_* functions and I'm
> > > > happy.
> > > >
> > > > Thanks!
> > > >         Manuel Lauss
> > >
> > > Here we go. Thanks !
> >
> > One last nit: please also add function prototypes to the gpio header.
> 
> Right, sorry about that.
> --
> From: Florian Fainelli <florian@openwrt.org>
> Subject: [PATCH v4] Alchemy: convert to gpiolib
> 
> This patch converts Alchemy SoC GPIO code to use
> gpiolib instead of the old GENERIC_GPIO implementation.
> 
> Changes from v3:
> - add function prototypes in gpio header
> 
> Changes from v2:
> - export all gpio accessors so that custom boards can use them
> 
> Changes from v1:
> - allow users not to use the default gpio accessors
> - do not lock au1000_gpio2_set
> 
> Signed-off-by: Florian Fainelli <florian@openwrt.org>

Acked-by: Manuel Lauss <mano@roarinelk.homelinux.net>


Thank you!
        Manuel Lauss

<Prev in Thread] Current Thread [Next in Thread>