linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: rb532: remove unused rb532_gpio_set_func()

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: rb532: remove unused rb532_gpio_set_func()
From: Phil Sutter <n0-1@freewrt.org>
Date: Thu, 22 Jan 2009 01:41:34 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20081128194353.DC55A386DBBE@mail.ifyouseekate.net>
Mail-followup-to: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20081128193322.D103C386DBBE@mail.ifyouseekate.net> <20081128194353.DC55A386DBBE@mail.ifyouseekate.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.11
Hi,

On Fri, Nov 28, 2008 at 08:46:29PM +0100, Phil Sutter wrote:
> Since disabling of the alternate function of a GPIO pin is being done
> implicitly when changing it's direction, the above mentioned function is
> not being called anymore and can be removed.

Please do not apply this patch. In fact, the function in question should
be exported as kernel symbol, as else there is no possibility for
drivers to turn on alternate function for a GPIO pin. This is of
particular use when trying to read the S1 button state, as the
corresponding GPIO pin is multiplexed with UART0 input.

Greetings, Phil

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] MIPS: rb532: remove unused rb532_gpio_set_func(), Phil Sutter <=