linux-mips
[Top] [All Lists]

[PATCH 2/5] MIPS: rb532: fix set_latch_u5()

To: Linux-Mips List <linux-mips@linux-mips.org>
Subject: [PATCH 2/5] MIPS: rb532: fix set_latch_u5()
From: Phil Sutter <n0-1@freewrt.org>
Date: Mon, 19 Jan 2009 23:42:51 +0100
Cc: ralf@linux-mips.org, florian@openwrt.org
In-reply-to: <1232404974-18497-1-git-send-email-n0-1@freewrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1232404974-18497-1-git-send-email-n0-1@freewrt.org>
Sender: linux-mips-bounce@linux-mips.org
The data to be written is just a byte, so use writeb instead of writel.
Also, dev3.base contains the address, not the data so referencing here
is wrong.

Signed-off-by: Phil Sutter <n0-1@freewrt.org>
---
 arch/mips/rb532/gpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/rb532/gpio.c b/arch/mips/rb532/gpio.c
index 40deb11..7e0cb4f 100644
--- a/arch/mips/rb532/gpio.c
+++ b/arch/mips/rb532/gpio.c
@@ -93,7 +93,7 @@ void set_latch_u5(unsigned char or_mask, unsigned char 
nand_mask)
        spin_lock_irqsave(&dev3.lock, flags);
 
        dev3.state = (dev3.state | or_mask) & ~nand_mask;
-       writel(dev3.state, &dev3.base);
+       writeb(dev3.state, dev3.base);
 
        spin_unlock_irqrestore(&dev3.lock, flags);
 }
-- 
1.5.6.4


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 2/5] MIPS: rb532: fix set_latch_u5(), Phil Sutter <=