linux-mips
[Top] [All Lists]

Re: [PATCH] au1000: convert to using gpiolib

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH] au1000: convert to using gpiolib
From: Manuel Lauss <mano@roarinelk.homelinux.net>
Date: Fri, 16 Jan 2009 18:47:53 +0100
Cc: ralf@linux-mips.org, Linux-MIPS <linux-mips@linux-mips.org>
In-reply-to: <86ee6fd0901160210pdb7f52nf761f8706a56f8fe@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200901151646.49591.florian@openwrt.org> <20090115205851.GD8656@roarinelk.homelinux.net> <86ee6fd0901160210pdb7f52nf761f8706a56f8fe@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.16 (2007-06-09)
Hi Florian,

On Fri, Jan 16, 2009 at 11:10:25AM +0100, Florian Fainelli wrote:
> > Can you please make the gpiolib registration dependent on a
> > CONFIG symbol?  I.e. make the au1000_gpio{,2}_direction() and
> > friends calls globally visible but let the individual boards
> > decide whether they want to use the gpio numbering imposed by
> > this patch.
> 
> 
> Would something like #ifdef CONFIG_AU1000_NON_STD_GPIOS be ok with you ?
> Or maybe we could get the base information from board-specific code ?

Well, we could move the core_initcall() to all boards' setup function,
and stick a comment on top of it explaining why it's there.

Config symbol or the above, either is fine with me.

Thanks!
        Manuel Lauss

<Prev in Thread] Current Thread [Next in Thread>