linux-mips
[Top] [All Lists]

Re: [PATCH] tx4939ide: Do not use zero count PRD entry

To: sshtylyov@ru.mvista.com
Subject: Re: [PATCH] tx4939ide: Do not use zero count PRD entry
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Fri, 16 Jan 2009 23:25:27 +0900 (JST)
Cc: linux-ide@vger.kernel.org, bzolnier@gmail.com, linux-mips@linux-mips.org, stable@kernel.org
In-reply-to: <497082D1.5030504@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1230215558-9197-1-git-send-email-anemo@mba.ocn.ne.jp> <497082D1.5030504@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 16 Jan 2009 15:51:29 +0300, Sergei Shtylyov <sshtylyov@ru.mvista.com> 
wrote:
> > +                    * This workaround for zero count seems required.
> > +                    * (standard ide_build_dmatable do it too)
> 
>     s/do/does/

Thanks!

> > +                   if ((bcount & 0xffff) == 0x0000)
> 
>    Why not just bcount == 0x10000?

Indeed.  It is just because ide_build_dmatable does so :)

I will prepare another patch, while the patch is already mainlined and
queued for stable, and this time changes are not suitable for stable
tree.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>