| To: | David Daney <ddaney@caviumnetworks.com> |
|---|---|
| Subject: | Re: [PATCH 2/2] libata: New driver for OCTEON SOC Compact Flash interface (v6). |
| From: | Alan Cox <alan@lxorguk.ukuu.org.uk> |
| Date: | Thu, 15 Jan 2009 21:13:33 +0000 |
| Cc: | linux-ide@vger.kernel.org, linux-mips@linux-mips.org, David Daney <ddaney@caviumnetworks.com> |
| In-reply-to: | <1232053053-16232-2-git-send-email-ddaney@caviumnetworks.com> |
| Organization: | Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <496FA2E9.9030403@caviumnetworks.com> <1232053053-16232-2-git-send-email-ddaney@caviumnetworks.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
> + reg_cfg.s.orbit = 0; /* Don't combine with previos region */ previous ... > +static unsigned int octeon_cf_qc_issue(struct ata_queued_cmd *qc) > + case ATAPI_PROT_DMA: > + dev_err(ap->dev, "Error, ATAPI not supported\n"); > + BUG(); Looks as if you should also have a check_atapi_dma function that always returns non zero (or a mode filter for atapi -> pio) Looks good to me. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] au1000: convert to using gpiolib, Manuel Lauss |
|---|---|
| Next by Date: | [PATCH 0/2] libata: Add OCTEON Compact Flash driver (v7)., David Daney |
| Previous by Thread: | [PATCH 2/2] libata: New driver for OCTEON SOC Compact Flash interface (v6)., David Daney |
| Next by Thread: | [PATCH 0/2] libata: Add OCTEON Compact Flash driver (v7)., David Daney |
| Indexes: | [Date] [Thread] [Top] [All Lists] |