linux-mips
[Top] [All Lists]

Re: [PATCH 06/14] MIPS: print irq handler description

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH 06/14] MIPS: print irq handler description
From: Manuel Lauss <mano@roarinelk.homelinux.net>
Date: Thu, 15 Jan 2009 21:22:10 +0100
Cc: Linux-MIPS <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>
In-reply-to: <496F9579.7050300@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1229846410.git.mano@roarinelk.homelinux.net> <caebb02f97491d8e5830438e1a746b0e02fa2c7c.1229846411.git.mano@roarinelk.homelinux.net> <80cf5c7a0db39a7230bae7766264acbfc68d200e.1229846412.git.mano@roarinelk.homelinux.net> <e6862a9acc480a4f00d0b7ae738e8a355a7e4810.1229846412.git.mano@roarinelk.homelinux.net> <ac2064c64b746420a21008fa4e9e7c4ecf048d7a.1229846413.git.mano@roarinelk.homelinux.net> <dc79b2a4d9da426f867de084c75940109eff1287.1229846413.git.mano@roarinelk.homelinux.net> <535458cb8c8f570089b2712a1e73ca7314d5b7c7.1229846413.git.mano@roarinelk.homelinux.net> <496F90AA.7070407@caviumnetworks.com> <20090115194921.GB8656@roarinelk.homelinux.net> <496F9579.7050300@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.16 (2007-06-09)
David,

On Thu, Jan 15, 2009 at 11:58:49AM -0800, David Daney wrote:
> Manuel Lauss wrote:
> [...]
>> Or how about this?
> [...]                 seq_printf(p, " %14s", irq_desc[i].chip->name);
>> -            seq_printf(p, "-%-8s", irq_desc[i].name);
>> +            if (irq_desc[i].name)
>> +                    seq_printf(p, "-%-8s", irq_desc[i].name);
>>              seq_printf(p, "  %s", action->name);
>
> I will let you and Ralf decide.  However it would be nice if action->name 
> lined up with a mixture of NULL and non-NULL irq_desc[i].name.  It is not 
> clear to me if this is the case with your patch.

Good point, no it's not the case unfortunately; the gap between
the controller and irq names becomes unaesthetically wide.

So please revert the patch.

Thanks!
        Manuel Lauss

<Prev in Thread] Current Thread [Next in Thread>