linux-mips
[Top] [All Lists]

Re: [PATCH] Don't use ttyS* serial device name for board specific PNX8XX

To: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
Subject: Re: [PATCH] Don't use ttyS* serial device name for board specific PNX8XXX UART serial
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Thu, 15 Jan 2009 01:04:14 +0300
Cc: linux-mips@linux-mips.org
In-reply-to: <1231943742.8457.6.camel@EPBYMINW0568>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1231943742.8457.6.camel@EPBYMINW0568>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.19 (Windows/20081209)
Hello.

Ihar Hrachyshka wrote:
I think that's a better solution for the problem I said so please commit
this patch rather previous one...

Such comments are to be placed after --- tearline. Using several such tearlines makes it harder to apply your patch... And why do you expect the MIPS maintainer to commit a patch to the serial driver? Such patches should be addressed to linux-serial@vger.kernel.org and (most probably) Alan Cox...

---

Don't use ttyS[0-1] serial device name for board specific PNX8XXX UART
serial. Rather create ttyPNX[0-1]. Also changed minor number to be
different with sa1100 serial driver one.

Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
[...]
diff --git a/drivers/serial/pnx8xxx_uart.c b/drivers/serial/pnx8xxx_uart.c
index 22e30d2..96870f1 100644
--- a/drivers/serial/pnx8xxx_uart.c
+++ b/drivers/serial/pnx8xxx_uart.c
@@ -34,9 +34,8 @@
 #include <asm/io.h>
 #include <asm/irq.h>
-/* We'll be using StrongARM sa1100 serial port major/minor */
 #define SERIAL_PNX8XXX_MAJOR   204
-#define MINOR_START            5
+#define MINOR_START            96

This major-minor pair is reserved for the Altix serial cards. Have you tried registering the minor on http://www.lanana.org

WBR, Sergei



<Prev in Thread] Current Thread [Next in Thread>