linux-mips
[Top] [All Lists]

Re: [PATCH] 8250: Initialize more fields in early_serial_setup.

To: linux-mips@linux-mips.org
Subject: Re: [PATCH] 8250: Initialize more fields in early_serial_setup.
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 14 Jan 2009 09:30:52 -0800
In-reply-to: <1231879604-30140-1-git-send-email-ddaney@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1231879604-30140-1-git-send-email-ddaney@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.19 (X11/20090105)
David Daney wrote:
The initial patch that initialized the fields individually omitted a
couple that evidently are required by mips/rb532.  This should fix it.

Signed-off-by: David Daney <ddaney@caviumnetworks.com>
---
 drivers/serial/8250.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 1889a63..e2c3a85 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -2837,6 +2837,8 @@ int __init early_serial_setup(struct uart_port *port)
        p->regshift     = port->regshift;
        p->iotype       = port->iotype;
        p->flags        = port->flags;
+       p->type              = port->type;
+       p->line              = port->line;
        p->mapbase      = port->mapbase;
        p->private_data = port->private_data;
Some one got to this before I did. Linus already committed a substantially similar patch as 125c97d8a59888c5678734c2b70cbd08c847bd99

David Daney

<Prev in Thread] Current Thread [Next in Thread>