linux-mips
[Top] [All Lists]

Re: [PATCH] cpumask fallout: Initialize irq_default_affinity earlier.

To: Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] cpumask fallout: Initialize irq_default_affinity earlier.
From: Rusty Russell <rusty@rustcorp.com.au>
Date: Sat, 10 Jan 2009 15:41:13 +1030
Cc: David Daney <ddaney@caviumnetworks.com>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <alpine.LFD.2.00.0901081256170.3283@localhost.localdomain>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1231446081-8448-1-git-send-email-ddaney@caviumnetworks.com> <496666CE.3050205@caviumnetworks.com> <alpine.LFD.2.00.0901081256170.3283@localhost.localdomain>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.10.3 (Linux/2.6.27-9-generic; KDE/4.1.3; i686; ; )
On Friday 09 January 2009 07:26:59 Linus Torvalds wrote:
> 
> On Thu, 8 Jan 2009, David Daney wrote:
> > 
> > The 'inline' seems gratuitous to me.  Since it is static GCC should do 
> > the Right Thing.  However since you suggested it, I am testing it that 
> > way.
> 
> Trust me, gcc very seldom does the Right Thing(tm) when it comes to 
> inlining. 
> 
>                       Linus

Note that there's a downside: with inline funcs in .c files you don't get
a warning should they become unused in future cleanups.

Cheers,
Rusty.

<Prev in Thread] Current Thread [Next in Thread>