| To: | David Daney <ddaney@caviumnetworks.com> |
|---|---|
| Subject: | Re: [PATCH] cpumask fallout: Initialize irq_default_affinity earlier. |
| From: | Mike Travis <travis@sgi.com> |
| Date: | Thu, 08 Jan 2009 13:25:47 -0800 |
| Cc: | Linus Torvalds <torvalds@linux-foundation.org>, rusty@rustcorp.com.au, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org |
| In-reply-to: | <496666CE.3050205@caviumnetworks.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1231446081-8448-1-git-send-email-ddaney@caviumnetworks.com> <alpine.LFD.2.00.0901081227360.3283@localhost.localdomain> <496666CE.3050205@caviumnetworks.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Thunderbird 2.0.0.6 (X11/20070801) |
David Daney wrote:
> Linus Torvalds wrote:
> [...]
>> In fact, I think it already is a no-op in the UP case, and you can
>> literally just do
>>
>> static inline void __init init_irq_default_affinity(void)
>> {
>> alloc_cpumask_var(&irq_default_affinity, GFP_KERNEL);
>> cpumask_setall(irq_default_affinity);
>> }
>>
>> and be done with it. I think it should all compile away to nothing if
>> CONFIG_SMP isn't set.
>
> The 'inline' seems gratuitous to me. Since it is static GCC should do
> the Right Thing. However since you suggested it, I am testing it that way.
>
> David Daney
It will probably need to be:
alloc_bootmem_cpumask_var(&irq_default_affinity);
I am testing it on x86_64 as well.
Thanks,
Mike
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] cpumask fallout: Initialize irq_default_affinity earlier., Linus Torvalds |
|---|---|
| Next by Date: | [PATCH 0/2] cpumask fallout: Initialize irq_default_affinity earlier et al., David Daney |
| Previous by Thread: | Re: [PATCH] cpumask fallout: Initialize irq_default_affinity earlier., Rusty Russell |
| Next by Thread: | [PATCH 0/2] cpumask fallout: Initialize irq_default_affinity earlier et al., David Daney |
| Indexes: | [Date] [Thread] [Top] [All Lists] |