linux-mips
[Top] [All Lists]

Re: [PATCH] cpumask fallout: Initialize irq_default_affinity earlier.

To: Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] cpumask fallout: Initialize irq_default_affinity earlier.
From: David Daney <ddaney@caviumnetworks.com>
Date: Thu, 08 Jan 2009 12:49:18 -0800
Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <alpine.LFD.2.00.0901081227360.3283@localhost.localdomain>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1231446081-8448-1-git-send-email-ddaney@caviumnetworks.com> <alpine.LFD.2.00.0901081227360.3283@localhost.localdomain>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.19 (X11/20090105)
Linus Torvalds wrote:
[...]
In fact, I think it already is a no-op in the UP case, and you can literally just do

        static inline void __init init_irq_default_affinity(void)
        {
                alloc_cpumask_var(&irq_default_affinity, GFP_KERNEL);
                cpumask_setall(irq_default_affinity);
        }

and be done with it. I think it should all compile away to nothing if CONFIG_SMP isn't set.

The 'inline' seems gratuitous to me. Since it is static GCC should do the Right Thing. However since you suggested it, I am testing it that way.

David Daney

<Prev in Thread] Current Thread [Next in Thread>