linux-mips
[Top] [All Lists]

Re: NXP STB225 board support

To: "Kevin D. Kissell" <kevink@paralogos.com>
Subject: Re: NXP STB225 board support
From: David Daney <ddaney@caviumnetworks.com>
Date: Thu, 08 Jan 2009 11:42:04 -0800
Cc: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>, linux-mips@linux-mips.org
In-reply-to: <496652B7.60500@paralogos.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <fce2a370812230648s798ebbf6y1387a237ae640e39@mail.gmail.com> <fce2a370901080858s345a33a6x3a2f821a7d9645b8@mail.gmail.com> <496652B7.60500@paralogos.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.19 (X11/20090105)
Kevin D. Kissell wrote:
Ihar Hrachyshka wrote:
 >
 >
 > Bisecting my Linus vanilla git, I found that the problem appeared
 > after the following patch was applied:
 >
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=566f74f6b2f8b85d5b8d6caaf97e5672cecd3e3e
 >
 > After reverting the patch, Linus vanilla git kernel again boots ok on
 > the board. Please, take a look.

Could one of the Cavium guys explain why the new code for V2 cores does
"ebase += ..."  and not "ebase = "?



We need to add the offset to the proper segment (CAC_BASE).

That said, the change to set_uncached_handler looks incorrect. It should be adding onto uncached_ebase not ebase.

Someone should probably fix that.

David Daney

<Prev in Thread] Current Thread [Next in Thread>