Re: [PATCH 3/3] netdev: New driver for OCTEON's MGMT ethernet devices.

[David Miller <davem@davemloft.net>]

From: David Daney <ddaney@caviumnetworks.com>
Date: Fri, 19 Dec 2008 15:43:12 -0800

> +#define CVMX_MDIO_PHY_REG_CONTROL 0
> +union cvmx_mdio_phy_reg_control {
> +     uint16_t u16;
> +     struct {
> +             uint16_t reset:1;
> +             uint16_t loopback:1;
> +             uint16_t speed_lsb:1;

Please use the standard Linux in-kernel types for fixed sized
integers, such as u16, u32, etc.

Having a union member named the same as a standard type defined in the
kernel is very confusing.