linux-mips
[Top] [All Lists]

Re: [PATCH 3/3] netdev: New driver for OCTEON's MGMT ethernet devices.

To: ddaney@caviumnetworks.com
Subject: Re: [PATCH 3/3] netdev: New driver for OCTEON's MGMT ethernet devices.
From: David Miller <davem@davemloft.net>
Date: Thu, 25 Dec 2008 16:52:19 -0800 (PST)
Cc: linux-mips@linux-mips.org, netdev@vger.kernel.org
In-reply-to: <1229730192-11870-3-git-send-email-ddaney@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <494C312E.9000901@caviumnetworks.com> <1229730192-11870-3-git-send-email-ddaney@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
From: David Daney <ddaney@caviumnetworks.com>
Date: Fri, 19 Dec 2008 15:43:12 -0800

> +#define CVMX_MDIO_PHY_REG_CONTROL 0
> +union cvmx_mdio_phy_reg_control {
> +     uint16_t u16;
> +     struct {
> +             uint16_t reset:1;
> +             uint16_t loopback:1;
> +             uint16_t speed_lsb:1;

Please use the standard Linux in-kernel types for fixed sized
integers, such as u16, u32, etc.

Having a union member named the same as a standard type defined in the
kernel is very confusing.

<Prev in Thread] Current Thread [Next in Thread>