linux-mips
[Top] [All Lists]

Re: [PATCH 1/3] libata: Add another column to the ata_timing table.

To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH 1/3] libata: Add another column to the ata_timing table.
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 10 Dec 2008 17:50:33 -0800
Cc: linux-ide@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <49405640.4020205@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <494052D1.10208@caviumnetworks.com> <1228952353-12323-1-git-send-email-ddaney@caviumnetworks.com> <49405640.4020205@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.18 (X11/20081119)
Sergei Shtylyov wrote:
Hello.

David Daney wrote:
The forthcoming OCTEON SOC Compact Flash driver needs an additional
timing value that was not available in the ata_timing table.  I add a
new column for dmack_hold time.  The values were obtained from the
Compact Flash specification Rev 4.1.

Note that I wasn't telling you to drop t4, just to correct its value for SWDMA modes.


I decided I don't need it, so I tried to drop it...


Signed-off-by: David Daney <ddaney@caviumnetworks.com>

  NAK, patch broken.

[...]

@@ -864,6 +866,8 @@ struct ata_timing {
     unsigned short cyc8b;        /* t0 for 8-bit I/O */
     unsigned short active;        /* t2 or tD */
     unsigned short recover;        /* t2i or tK */
+    unsigned short write_hold;    /* t4 */
+    unsigned short dmack_hold;    /* tj */
     unsigned short cycle;        /* t0 */
     unsigned short udma;        /* t2CYCTYP/2 */
 };

This is broken. You're still adding 2 fields but initializer doesný much that.


Sorry about that.  I am testing a fixed version.

David Daney

<Prev in Thread] Current Thread [Next in Thread>