linux-mips
[Top] [All Lists]

Re: [PATCH 1/4] 8250: Don't clobber spinlocks.

To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 1/4] 8250: Don't clobber spinlocks.
From: David Daney <ddaney@caviumnetworks.com>
Date: Tue, 02 Dec 2008 09:01:13 -0800
Cc: linux-serial@vger.kernel.org, akpm@linux-foundation.org, linux-mips@linux-mips.org, Tomaso Paoletti <tpaoletti@caviumnetworks.com>
In-reply-to: <20081202112010.6b25af1c@lxorguk.ukuu.org.uk>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4934774E.6080805@caviumnetworks.com> <1228175368-5536-1-git-send-email-ddaney@caviumnetworks.com> <20081202112010.6b25af1c@lxorguk.ukuu.org.uk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.16 (X11/20080723)
Alan Cox wrote:
On Mon,  1 Dec 2008 15:49:25 -0800
David Daney <ddaney@caviumnetworks.com> wrote:

In serial8250_isa_init_ports(), the port's lock is initialized.  We
should not overwrite it.  In early_serial_setup(), only copy in the
fields we need.  Since the early console code only uses a subset of
the fields, these are sufficient.

-       serial8250_ports[port->line].port.ops        = &serial8250_pops;

You seem to drop the assignment of port.ops ?


The port.ops are initialized in the preceding call to serial8250_isa_init_ports(), we don't have to set it again as we are no longer clobbering it with a full structure assignment.

Perhaps the patch commentary should be adjusted to mention this.

David Daney

<Prev in Thread] Current Thread [Next in Thread>