Re: [PATCH 1/4] 8250: Don't clobber spinlocks.

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

On Mon,  1 Dec 2008 15:49:25 -0800
David Daney <ddaney@caviumnetworks.com> wrote:

> In serial8250_isa_init_ports(), the port's lock is initialized.  We
> should not overwrite it.  In early_serial_setup(), only copy in the
> fields we need.  Since the early console code only uses a subset of
> the fields, these are sufficient.

> -     serial8250_ports[port->line].port.ops   = &serial8250_pops;

You seem to drop the assignment of port.ops ?