linux-mips
[Top] [All Lists]

Re: [PATCH 1/4] 8250: Don't clobber spinlocks.

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH 1/4] 8250: Don't clobber spinlocks.
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Tue, 2 Dec 2008 11:20:10 +0000
Cc: linux-serial@vger.kernel.org, akpm@linux-foundation.org, linux-mips@linux-mips.org, David Daney <ddaney@caviumnetworks.com>, Tomaso Paoletti <tpaoletti@caviumnetworks.com>
In-reply-to: <1228175368-5536-1-git-send-email-ddaney@caviumnetworks.com>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4934774E.6080805@caviumnetworks.com> <1228175368-5536-1-git-send-email-ddaney@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
On Mon,  1 Dec 2008 15:49:25 -0800
David Daney <ddaney@caviumnetworks.com> wrote:

> In serial8250_isa_init_ports(), the port's lock is initialized.  We
> should not overwrite it.  In early_serial_setup(), only copy in the
> fields we need.  Since the early console code only uses a subset of
> the fields, these are sufficient.

> -     serial8250_ports[port->line].port.ops   = &serial8250_pops;

You seem to drop the assignment of port.ops ?

<Prev in Thread] Current Thread [Next in Thread>