linux-mips
[Top] [All Lists]

[PATCH] MIPS: rb532: remove useless CF GPIO initialisation

To: Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH] MIPS: rb532: remove useless CF GPIO initialisation
From: Phil Sutter <n0-1@freewrt.org>
Date: Fri, 28 Nov 2008 20:46:22 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20081128193322.D103C386DBBE@mail.ifyouseekate.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20081128193322.D103C386DBBE@mail.ifyouseekate.net>
Sender: linux-mips-bounce@linux-mips.org
As the pata-rb532-cf driver calls gpio_set_direction_input(), the calls
to rb532_gpio_set_func() and rb532_gpio_direction_input() are not needed
since the alternate function is automatically being disabled when
changing the GPIO pin direction.
The later two calls to rb532_gpio_set_{ilevel,istat}() are implicitly
being done by the IRQ initialisation of pata-rb532-cf.

Signed-off-by: Phil Sutter <n0-1@freewrt.org>
---
 arch/mips/rb532/gpio.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/arch/mips/rb532/gpio.c b/arch/mips/rb532/gpio.c
index f5b15a1..b195f79 100644
--- a/arch/mips/rb532/gpio.c
+++ b/arch/mips/rb532/gpio.c
@@ -259,12 +259,6 @@ int __init rb532_gpio_init(void)
                return -ENXIO;
        }
 
-       /* configure CF_GPIO_NUM as CFRDY IRQ source */
-       rb532_gpio_set_func(0, CF_GPIO_NUM);
-       rb532_gpio_direction_input(&rb532_gpio_chip->chip, CF_GPIO_NUM);
-       rb532_gpio_set_ilevel(1, CF_GPIO_NUM);
-       rb532_gpio_set_istat(0, CF_GPIO_NUM);
-
        return 0;
 }
 arch_initcall(rb532_gpio_init);
-- 
1.5.6.4


<Prev in Thread] Current Thread [Next in Thread>