linux-mips
[Top] [All Lists]

Re: [PATCH v2] Alchemy: cpu feature override constants.

To: Manuel Lauss <mano@roarinelk.homelinux.net>
Subject: Re: [PATCH v2] Alchemy: cpu feature override constants.
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Wed, 26 Nov 2008 15:48:21 +0300
Cc: LMO <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>
In-reply-to: <20081125231230.GA10366@roarinelk.homelinux.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20081125231230.GA10366@roarinelk.homelinux.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.18 (Windows/20081105)
Hello.

Manuel Lauss wrote:

Add cpu feature override constants for Alchemy.

This helps code generation: fls() for instance is compiled without
using the clz instruction; other macros which do runtime feature
detection fall back on safe legacy code as well.  Adding this override
fixes that.  As a sideeffect, the size of a kernel built with an
extended db1200 defconfig is reduced by over 200kB:

   text    data     bss     dec     hex filename
3901089  124160  436528 4461777  4414d1 vmlinux
3676433  124096  436528 4237057  40a701 vmlinux-patched

  Great!

Signed-off-by: Manuel Lauss <mano@roarinelk.homelinux.net>

  The whitespace police on the road. :-)

diff --git a/arch/mips/include/asm/mach-au1x00/cpu-feature-overrides.h 
b/arch/mips/include/asm/mach-au1x00/cpu-feature-overrides.h
new file mode 100644
index 0000000..c22492e
--- /dev/null
+++ b/arch/mips/include/asm/mach-au1x00/cpu-feature-overrides.h
@@ -0,0 +1,51 @@
[...]
+
+#define cpu_dcache_line_size() 32
+#define cpu_icache_line_size()  32

  Inconsistent alignment.

WBR, Sergei



<Prev in Thread] Current Thread [Next in Thread>