linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] libata: Add three more columns to the ata_timing table.

To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH 1/2] libata: Add three more columns to the ata_timing table.
From: David Daney <ddaney@caviumnetworks.com>
Date: Tue, 25 Nov 2008 11:09:45 -0800
Cc: linux-ide@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <492C4936.2030305@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <492B56B0.9030409@caviumnetworks.com> <1227577181-30206-1-git-send-email-ddaney@caviumnetworks.com> <492BDB28.8020103@ru.mvista.com> <492C2BCE.60409@caviumnetworks.com> <492C4936.2030305@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.16 (X11/20080723)
Sergei Shtylyov wrote:
David Daney wrote:

Wrong, -DIOR hold time is 5 ns for MWDMA0 as well as for all other modes.

Point taken.

Besides, I'm not sure how useful that timing could be for the host controller since it's apparently not determined by the host side -- it's for how long the device holds valid data after -DIOR is released IIRC.


Yes, I think you are correct. This is a property of the device and cannot be controlled by the driver, so I will just remove this column in the next version of the patch.

David Daney

<Prev in Thread] Current Thread [Next in Thread>