Re: [PATCH 1/2] libata: Add three more columns to the ata_timing table.

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Alan Cox wrote:

> > > The forthcoming OCTEON SOC Compact Flash driver needs a few more
> > > timing values than were available in the ata_timing table.  I add new
> > > columns for write_hold, read_hold, and read_holdz times.  The values
> > > were obtained from the Compact Flash specification Rev 4.1.
> > > Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> > > ---
> > > drivers/ata/libata-core.c |   76 ++++++++++++++++++++++++--------------------
> > > include/linux/libata.h    |   14 ++++++--
> > > 2 files changed, 52 insertions(+), 38 deletions(-)
> > I would be happy to go ahead and apply this...  Alan, any last minute 
> > objections?
> Its close but I think Sergei is right about columns with all the same
> value - they can be constants and just computed into the final timing
> data in terms of clocks.
   The problem is that there's no exported libata API to compute just one 
arbitrary timing.
WBR, Sergei