linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] libata: Add three more columns to the ata_timing table.

To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 1/2] libata: Add three more columns to the ata_timing table.
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Tue, 25 Nov 2008 21:41:38 +0300
Cc: Jeff Garzik <jeff@garzik.org>, David Daney <ddaney@caviumnetworks.com>, linux-ide@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <20081125171224.297931b2@lxorguk.ukuu.org.uk>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <492B56B0.9030409@caviumnetworks.com> <1227577181-30206-1-git-send-email-ddaney@caviumnetworks.com> <492C2F23.8050105@garzik.org> <20081125171224.297931b2@lxorguk.ukuu.org.uk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
Hello.

Alan Cox wrote:

The forthcoming OCTEON SOC Compact Flash driver needs a few more
timing values than were available in the ata_timing table.  I add new
columns for write_hold, read_hold, and read_holdz times.  The values
were obtained from the Compact Flash specification Rev 4.1.

Signed-off-by: David Daney <ddaney@caviumnetworks.com>
---
drivers/ata/libata-core.c |   76 ++++++++++++++++++++++++--------------------
include/linux/libata.h    |   14 ++++++--
2 files changed, 52 insertions(+), 38 deletions(-)

I would be happy to go ahead and apply this... Alan, any last minute objections?

Its close but I think Sergei is right about columns with all the same
value - they can be constants and just computed into the final timing
data in terms of clocks.

The problem is that there's no exported libata API to compute just one arbitrary timing.

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>