linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] libata: Add three more columns to the ata_timing table.

To: Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH 1/2] libata: Add three more columns to the ata_timing table.
From: David Daney <ddaney@caviumnetworks.com>
Date: Tue, 25 Nov 2008 09:04:49 -0800
Cc: linux-ide@vger.kernel.org, linux-mips@linux-mips.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
In-reply-to: <492C2F23.8050105@garzik.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <492B56B0.9030409@caviumnetworks.com> <1227577181-30206-1-git-send-email-ddaney@caviumnetworks.com> <492C2F23.8050105@garzik.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.16 (X11/20080723)
Jeff Garzik wrote:
David Daney wrote:
The forthcoming OCTEON SOC Compact Flash driver needs a few more
timing values than were available in the ata_timing table.  I add new
columns for write_hold, read_hold, and read_holdz times.  The values
were obtained from the Compact Flash specification Rev 4.1.

Signed-off-by: David Daney <ddaney@caviumnetworks.com>
---
drivers/ata/libata-core.c | 76 ++++++++++++++++++++++++--------------------
 include/linux/libata.h    |   14 ++++++--
 2 files changed, 52 insertions(+), 38 deletions(-)

I would be happy to go ahead and apply this... Alan, any last minute objections?


Sergei had some comments that I am trying to address. Perhaps we should hold off a little, while I figure out how what to do WRT those comments.

David Daney

<Prev in Thread] Current Thread [Next in Thread>