| To: | David Daney <ddaney@caviumnetworks.com> |
|---|---|
| Subject: | Re: [PATCH] MIPS: Make BUG() __noreturn. |
| From: | Alan Cox <alan@lxorguk.ukuu.org.uk> |
| Date: | Fri, 21 Nov 2008 10:00:35 +0000 |
| Cc: | linux-mips <linux-mips@linux-mips.org>, linux-kernel@vger.kernel.org |
| In-reply-to: | <49260E4C.8080500@caviumnetworks.com> |
| Organization: | Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <49260E4C.8080500@caviumnetworks.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Thu, 20 Nov 2008 17:26:36 -0800 David Daney <ddaney@caviumnetworks.com> wrote: > MIPS: Make BUG() __noreturn. > > Often we do things like put BUG() in the default clause of a case > statement. Since it was not declared __noreturn, this could sometimes > lead to bogus compiler warnings that variables were used > uninitialized. > > There is a small problem in that we have to put a magic while(1); loop to > fool GCC into really thinking it is noreturn. That sounds like your __noreturn macro is wrong. Try using __attribute__ ((__noreturn__)) if that works then fix up the __noreturn definitions for the MIPS and gcc you have. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [rtc-linux] [PATCH 3/4] rtc: Add rtc-tx4939 driver, Atsushi Nemoto |
|---|---|
| Next by Date: | Re: [PATCH] ide: New libata driver for OCTEON SOC Compact Flash interface., Alan Cox |
| Previous by Thread: | [PATCH] MIPS: Make BUG() __noreturn., David Daney |
| Next by Thread: | Re: [PATCH] MIPS: Make BUG() __noreturn., Geert Uytterhoeven |
| Indexes: | [Date] [Thread] [Top] [All Lists] |