linux-mips
[Top] [All Lists]

Re: [PATCH/RFC v1 08/12] [MIPS] BCM63XX: Add USB EHCI support.

To: Maxime Bizon <mbizon@freebox.fr>
Subject: Re: [PATCH/RFC v1 08/12] [MIPS] BCM63XX: Add USB EHCI support.
From: David Brownell <david-b@pacbell.net>
Date: Mon, 17 Nov 2008 20:43:06 -0800
Cc: linux-mips@linux-mips.org, linux-usb@vger.kernel.org
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=pacbell.net; h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:Reply-To:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id; b=R7bJtJopVkfTH4sAcXCOSN4XBrmshywErsdt91N8bPb4+Ey5BD6XSHLZJUuIukdbwE9y1C53wgeBQdDtKKke2OrRVUvtK4Ea8iN8SK11QRmuHqZDfcrwU2KW3EuQdrzFFtkcHuTV8PdGXcKz7d4jPaX2JbS9xwr8aKNyLmZ3y1s= ;
In-reply-to: <1224382023-24364-1-git-send-email-mbizon@freebox.fr>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1224382023-24364-1-git-send-email-mbizon@freebox.fr>
Reply-to: dbrownell@users.sourceforge.net
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.10
On Saturday 18 October 2008, Maxime Bizon wrote:
>  arch/mips/bcm63xx/Kconfig                          |    2 +
>  arch/mips/bcm63xx/Makefile                         |    1 +
>  arch/mips/bcm63xx/dev-usb-ehci.c                   |   50 +++++++
>  .../asm/mach-bcm63xx/bcm63xx_dev_usb_ehci.h        |    6 +
>  drivers/usb/host/ehci-bcm63xx.c                    |  152 
> ++++++++++++++++++++
>  drivers/usb/host/ehci-hcd.c                        |    5 +
>  drivers/usb/host/ehci.h                            |    5 +

Same general comments as for OHCI.  Also, be sure the patch
comments actually include patch comments.  :)


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH/RFC v1 08/12] [MIPS] BCM63XX: Add USB EHCI support., David Brownell <=