linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] Alchemy: Move evalboard code to common directory

To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH 2/3] Alchemy: Move evalboard code to common directory
From: Manuel Lauss <mano@roarinelk.homelinux.net>
Date: Wed, 12 Nov 2008 13:05:28 +0100
Cc: Kevin Hickey <khickey@rmicorp.com>, Linux-MIPS <linux-mips@linux-mips.org>, Florian Fainelli <florian@openwrt.org>, Bruno Randolf <bruno.randolf@4g-systems.biz>
In-reply-to: <491AB16A.3050203@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1226143942.git.mano@roarinelk.homelinux.net> <0b1dcd4090411d59e2272ca94da0fb4f5a4bbceb.1226143942.git.mano@roarinelk.homelinux.net> <b66aea73a24b5eb990339845892f4a43ccd7efaa.1226143942.git.mano@roarinelk.homelinux.net> <1226462433.9026.12.camel@kh-d820-ubuntu.razamicroelectronics.com> <491AB16A.3050203@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.16 (2007-06-09)
Hello,

On Wed, Nov 12, 2008 at 01:35:22PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> Kevin Hickey wrote:
>
>> And in keeping with my other email, I think that the evalboards
>> directory is a good idea (though I would recommend the name
>> "develboards" as that is what DB stands for), but it should contain
>>   
>
>   I'd prefer devel-boards, or dev-boards.

Can we settle on "devboards" without the hyphen?  Everybody okay with that?


>> subdirectories for each board and a common directory for common DB code.
>> Smashing all of the board code into one file doesn't leave any room to
>> grow if that file gets too big.
>
>   I doubt that this could be the case here. And I don't think anybody has 
> placed limits on the source file size so far.
>
>> Also, a single common.c will not be sufficient in the future.
>>   
>
>   Wait, the file only includes prom_init() for now, so might be worth 
> renaming it...

I planned on putting some of the code currently living in common/ into it.
Not a good idea?  Then I'll rename it to prom.c and leave it alone.


Thoughts?

Thanks,
        Manuel Lauss

<Prev in Thread] Current Thread [Next in Thread>