linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] Alchemy: Move evalboard code to common directory

To: Manuel Lauss <mano@roarinelk.homelinux.net>
Subject: Re: [PATCH 2/3] Alchemy: Move evalboard code to common directory
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Wed, 12 Nov 2008 13:38:29 +0300
Cc: Kevin Hickey <khickey@rmicorp.com>, Linux-MIPS <linux-mips@linux-mips.org>, Florian Fainelli <florian@openwrt.org>, Bruno Randolf <bruno.randolf@4g-systems.biz>
In-reply-to: <20081112060630.GB9358@roarinelk.homelinux.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1226143942.git.mano@roarinelk.homelinux.net> <0b1dcd4090411d59e2272ca94da0fb4f5a4bbceb.1226143942.git.mano@roarinelk.homelinux.net> <b66aea73a24b5eb990339845892f4a43ccd7efaa.1226143942.git.mano@roarinelk.homelinux.net> <1226462433.9026.12.camel@kh-d820-ubuntu.razamicroelectronics.com> <20081112060630.GB9358@roarinelk.homelinux.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.17 (Windows/20080914)
Hello.

Manuel Lauss wrote:

And in keeping with my other email, I think that the evalboards
directory is a good idea (though I would recommend the name
"develboards" as that is what DB stands for), but it should contain
subdirectories for each board and a common directory for common DB code.
Smashing all of the board code into one file doesn't leave any room to
grow if that file gets too big.  Also, a single common.c will not be
sufficient in the future.

Okay, I'll change that, test and resend.

Thanks,
        Manuel Lauss
[...]

Move all code of the Pb/Db boards to a single subdirectory and extract
some common code.

Signed-off-by: Manuel Lauss <mano@roarinelk.homelinux.net>

  I see you, Manuel is no better. :-)
  Please avoid leaving unquoted patch behind your reply.

WBR, Sergei



<Prev in Thread] Current Thread [Next in Thread>