|To:||Martin Gebert <firstname.lastname@example.org>|
|Subject:||Re: AU1000: SSI0 naming inconsistency|
|From:||Sergei Shtylyov <email@example.com>|
|Date:||Fri, 07 Nov 2008 01:50:44 +0300|
|User-agent:||Thunderbird 188.8.131.52 (Windows/20080914)|
Hello. Martin Gebert wrote:
Working on a 2.6.22 kernel for a AU1100 board, I came across the following inconsistency in register naming ininclude/asm/mach-au1x00/au1000.h, which still exists in 184.108.40.206 (lines 1334-1389). There's no register SSI0_CONTROL, it should be namedSSI0_ENABLE, as it is for SSI1: --8><-- #define SSI0_CONTROL 0xB1600100 #define SSI_CONTROL_CD (1<<1) #define SSI_CONTROL_E (1<<0) /* SSI1 */ [...] #define SSI1_ENABLE 0xB1680100 [...] #define SSI_ENABLE_CD (1<<1) #define SSI_ENABLE_E (1<<0) --><8-- As I'm not working on a current kernel repo I don't dare to provide a patch. Would fixing this be desirable?
This seems to be a only top of iceberg as the SSI register bits are all defined twice in the arch/mips/include/asm/mach-au1x00/au1000.h. I wonder why gcc ignores macro redefinitions... Patch is welcome but be sure not to break the users of those macros (if there are any :-)...
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||[PATCH 29/29] MIPS: Add defconfig for Cavium OCTEON., David Daney|
|Next by Date:||Re: [PATCH 18/29] MIPS: Add SMP_ICACHE_FLUSH for the Cavium CPU family., Sergei Shtylyov|
|Previous by Thread:||AU1000: SSI0 naming inconsistency, Martin Gebert|
|Next by Thread:||[PATCH 00/29] Add Cavium OCTEON processor support (v3)., David Daney|
|Indexes:||[Date] [Thread] [Top] [All Lists]|