linux-mips
[Top] [All Lists]

Re: [rtc-linux] Re: [RFC PATCH] Au1xxx on-chip counter-as-RTC driver

To: Alessandro Zummo <alessandro.zummo@towertech.it>
Subject: Re: [rtc-linux] Re: [RFC PATCH] Au1xxx on-chip counter-as-RTC driver
From: Manuel Lauss <mano@roarinelk.homelinux.net>
Date: Wed, 5 Nov 2008 21:44:53 +0100
Cc: rtc-linux@googlegroups.com, Linux-MIPS <linux-mips@linux-mips.org>, Kevin Hickey <khickey@rmicorp.com>
In-reply-to: <20081105015353.18130dbc@i1501.lan.towertech.it>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080809161402.15e24b2e@flagship.roarinelk.net> <20081021203815.1a0a246d@i1501.lan.towertech.it> <20081022073114.GA11169@roarinelk.homelinux.net> <20081028111704.2feb3b53@i1501.lan.towertech.it> <20081028105220.GA1235@roarinelk.homelinux.net> <20081105015353.18130dbc@i1501.lan.towertech.it>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.16 (2007-06-09)
Hi Alessandro,

On Wed, Nov 05, 2008 at 01:53:53AM +0100, Alessandro Zummo wrote:
> On Tue, 28 Oct 2008 11:52:20 +0100
> Manuel Lauss <mano@roarinelk.homelinux.net> wrote:
> 
>  Hi Manuel, some more comments
> 
> > +static int au1xtoy_rtc_read_time(struct device *dev, struct rtc_time *tm)
> > +{
> > +   unsigned long t;
> > +
> > +   t = au_readl(SYS_TOYREAD);
> > +
> > +   rtc_time_to_tm(t, tm);
> > +
> > +   if (rtc_valid_tm(tm) < 0) {
> > +           dev_err(dev, "invalid date stored in counter0\n");
> > +           rtc_time_to_tm(0, tm);
> > +   }
> > +
> > +   return 0;
> > +}
> 
> 
>  you should return an error if the date is invalid.
>  return rtc_valid_tm(tm) would do
> 
> 
> > +static int __devexit au1xtoy_rtc_remove(struct platform_device *pdev)
> > +{
> > +   struct rtc_device *rtcdev = platform_get_drvdata(pdev);
> > +
> > +   if (likely(rtcdev))
> 
>  no need to check
> 
> > +           rtc_device_unregister(rtcdev);
> > +
> > +   platform_set_drvdata(pdev, NULL);
> > +   return 0;
> > +}
> > +
> > +static struct platform_driver au1xtoy_rtc_platform_driver = {
> > +   .driver         = {
> > +           .name   = "rtc-au1xxx",
> > +           .owner  = THIS_MODULE,
> > +   },
> > +   .probe          = au1xtoy_rtc_probe,
> > +   .remove         = __devexit_p(au1xtoy_rtc_remove),
> > +};
> > +
> > +static int __init au1xtoy_rtc_init(void)
> > +{
> > +   return platform_driver_register(&au1xtoy_rtc_platform_driver);
> 
>  you should be using platform_driver_probe here which will require
>  __init/__exit instead of __devinit __devexit
> 
> > +}
> > +
> > +static void __exit au1xtoy_rtc_exit(void)
> > +{
> > +   platform_driver_unregister(&au1xtoy_rtc_platform_driver);
> > +}
> > +
> > +module_init(au1xtoy_rtc_init);
> > +module_exit(au1xtoy_rtc_exit);
> > +
> > +MODULE_DESCRIPTION("Au1xxx TOY-counter-based RTC driver");
> > +MODULE_AUTHOR("Manuel Lauss");
> 
>  email here please


All fixed, new version below.

Thank you!
        Manuel Lauss

---

From: Manuel Lauss <mano@roarinelk.homelinux.net>
Subject: [PATCH] RTC: Au1000 On-Chip Counter0-as-RTC driver.

Simple driver which uses the Au1xxx Time-Of-Year counter (counter0)
as a 1Hz RTC.

Signed-off-by: Manuel Lauss <mano@roarinelk.homelinux.net>
---
 drivers/rtc/Kconfig      |    9 +++
 drivers/rtc/Makefile     |    1 +
 drivers/rtc/rtc-au1xxx.c |  153 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 163 insertions(+), 0 deletions(-)
 create mode 100644 drivers/rtc/rtc-au1xxx.c

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 8abbb20..8431fda 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -604,6 +604,15 @@ config RTC_DRV_AT91SAM9_GPBR
          will be used.  The default of zero is normally OK to use, but
          on some systems other software needs to use that register.
 
+config RTC_DRV_AU1XXX
+       tristate "Au1xxx TOY-as-RTC support"
+       depends on SOC_AU1X00
+       help
+         This driver uses Au1000 on-chip Counter0 as a Real Time Clock.
+
+         This driver can also be built as a module. If so, the module
+         will be called rtc-au1xxx.
+
 config RTC_DRV_BFIN
        tristate "Blackfin On-Chip RTC"
        depends on BLACKFIN && !BF561
diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile
index e9e8474..cc213ab 100644
--- a/drivers/rtc/Makefile
+++ b/drivers/rtc/Makefile
@@ -20,6 +20,7 @@ rtc-core-$(CONFIG_RTC_INTF_SYSFS) += rtc-sysfs.o
 obj-$(CONFIG_RTC_DRV_AT32AP700X)+= rtc-at32ap700x.o
 obj-$(CONFIG_RTC_DRV_AT91RM9200)+= rtc-at91rm9200.o
 obj-$(CONFIG_RTC_DRV_AT91SAM9) += rtc-at91sam9.o
+obj-$(CONFIG_RTC_DRV_AU1XXX)   += rtc-au1xxx.o
 obj-$(CONFIG_RTC_DRV_BFIN)     += rtc-bfin.o
 obj-$(CONFIG_RTC_DRV_CMOS)     += rtc-cmos.o
 obj-$(CONFIG_RTC_DRV_DS1216)   += rtc-ds1216.o
diff --git a/drivers/rtc/rtc-au1xxx.c b/drivers/rtc/rtc-au1xxx.c
new file mode 100644
index 0000000..d94974d
--- /dev/null
+++ b/drivers/rtc/rtc-au1xxx.c
@@ -0,0 +1,153 @@
+/*
+ * Au1xxx counter0 (aka Time-of-year counter) RTC interface driver.
+ *
+ * Copyright (C) 2008 Manuel Lauss <mano@roarinelk.homelinux.net>
+ *
+ * This file is subject to the terms and conditions of the GNU General Public
+ * License.  See the file "COPYING" in the main directory of this archive
+ * for more details.
+ */
+
+/* All current Au1xxx SoCs have 2 counters fed by an external 32.768 kHz
+ * crystal. Counter 0, which keeps counting during sleep/powerdown, is
+ * used to count seconds since the beginning of the unix epoch.
+ *
+ * The counters must be configured and enabled by bootloader/board code;
+ * no checks as to whether they really get a proper 32.768kHz clock are
+ * made.
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/rtc.h>
+#include <linux/init.h>
+#include <linux/platform_device.h>
+#include <linux/io.h>
+#include <asm/mach-au1x00/au1000.h>
+
+/* 32kHz clock enabled and detected */
+#define CNTR_OK (SYS_CNTRL_E0 | SYS_CNTRL_32S)
+
+static int au1xtoy_rtc_read_time(struct device *dev, struct rtc_time *tm)
+{
+       unsigned long t;
+
+       t = au_readl(SYS_TOYREAD);
+
+       rtc_time_to_tm(t, tm);
+
+       return rtc_valid_tm(tm);
+}
+
+static int au1xtoy_rtc_set_time(struct device *dev, struct rtc_time *tm)
+{
+       unsigned long t;
+
+       rtc_tm_to_time(tm, &t);
+
+       au_writel(t, SYS_TOYWRITE);
+       au_sync();
+
+       /* wait for the pending register write to succeed.  This can
+        * take up to 6 seconds...
+        */
+       while (au_readl(SYS_COUNTER_CNTRL) & SYS_CNTRL_C0S)
+               schedule();
+
+       return 0;
+}
+
+static struct rtc_class_ops au1xtoy_rtc_ops = {
+       .read_time      = au1xtoy_rtc_read_time,
+       .set_time       = au1xtoy_rtc_set_time,
+};
+
+static int __devinit au1xtoy_rtc_probe(struct platform_device *pdev)
+{
+       struct rtc_device *rtcdev;
+       unsigned long t;
+       int ret;
+
+       t = au_readl(SYS_COUNTER_CNTRL);
+       if (!(t & CNTR_OK)) {
+               dev_err(&pdev->dev, "counters not working; aborting.\n");
+               ret = -ENODEV;
+               goto out_err;
+       }
+
+       ret = -ETIMEDOUT;
+
+       /* set counter0 tickrate to 1Hz if necessary */
+       if (au_readl(SYS_TOYTRIM) != 32767) {
+               /* wait until hardware gives access to TRIM register */
+               t = 0x00100000;
+               while ((au_readl(SYS_COUNTER_CNTRL) & SYS_CNTRL_T0S) && t--)
+                       schedule();
+
+               if (!t) {
+                       /* timed out waiting for register access; assume
+                        * counters are unusable.
+                        */
+                       dev_err(&pdev->dev, "timeout waiting for access\n");
+                       goto out_err;
+               }
+
+               /* set 1Hz TOY tick rate */
+               au_writel(32767, SYS_TOYTRIM);
+               au_sync();
+       }
+
+       /* wait until the hardware allows writes to the counter reg */
+       while (au_readl(SYS_COUNTER_CNTRL) & SYS_CNTRL_C0S)
+               schedule();
+
+       rtcdev = rtc_device_register("rtc-au1xxx", &pdev->dev,
+                                    &au1xtoy_rtc_ops, THIS_MODULE);
+       if (IS_ERR(rtcdev)) {
+               ret = PTR_ERR(rtcdev);
+               goto out_err;
+       }
+
+       platform_set_drvdata(pdev, rtcdev);
+
+       return 0;
+
+out_err:
+       return ret;
+}
+
+static int __devexit au1xtoy_rtc_remove(struct platform_device *pdev)
+{
+       struct rtc_device *rtcdev = platform_get_drvdata(pdev);
+
+       rtc_device_unregister(rtcdev);
+       platform_set_drvdata(pdev, NULL);
+
+       return 0;
+}
+
+static struct platform_driver au1xrtc_driver = {
+       .driver         = {
+               .name   = "rtc-au1xxx",
+               .owner  = THIS_MODULE,
+       },
+       .remove         = __devexit_p(au1xtoy_rtc_remove),
+};
+
+static int __init au1xtoy_rtc_init(void)
+{
+       return platform_driver_probe(&au1xrtc_driver, au1xtoy_rtc_probe);
+}
+
+static void __exit au1xtoy_rtc_exit(void)
+{
+       platform_driver_unregister(&au1xrtc_driver);
+}
+
+module_init(au1xtoy_rtc_init);
+module_exit(au1xtoy_rtc_exit);
+
+MODULE_DESCRIPTION("Au1xxx TOY-counter-based RTC driver");
+MODULE_AUTHOR("Manuel Lauss <manuel.lauss@gmail.com>");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:rtc-au1xxx");
-- 
1.6.0.3


<Prev in Thread] Current Thread [Next in Thread>