linux-mips
[Top] [All Lists]

Re: [PATCH]: R10000 Needs LL/SC Workaround in Glibc

To: James Perkins <james@loowit.net>
Subject: Re: [PATCH]: R10000 Needs LL/SC Workaround in Glibc
From: Kumba <kumba@gentoo.org>
Date: Tue, 04 Nov 2008 02:16:52 -0500
Cc: libc-ports@sources.redhat.com, Daniel Jacobowitz <drow@false.org>, Linux MIPS List <linux-mips@linux-mips.org>
In-reply-to: <490C907A.40005@loowit.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <490A912A.8030901@gentoo.org> <490C907A.40005@loowit.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.17 (Windows/20080914)
James Perkins wrote:
      "move        %1,%3\n\t"               \
      "sc  %1,%4\n\t"               \
-     "beqz        %1,1b\n"                 \
+     R10K_BEQZ_INSN                          \
      acq       "\n\t"                              \
      ".set        pop\n"                           \

Is it possible to leave the parameters in the inline code and
remove them from the macro definition? I feel the code is more
readable without having to refer to the macro definition if
the parameters are left in place.

Makes sense, I'll keep this in mind for the next patch revision I make.

--
Joshua Kinard
Gentoo/MIPS
kumba@gentoo.org

"The past tempts us, the present confuses us, the future frightens us. And our lives slip away, moment by moment, lost in that vast, terrible in-between."

--Emperor Turhan, Centauri Republic

<Prev in Thread] Current Thread [Next in Thread>