linux-mips
[Top] [All Lists]

Re: [PATCH] rb532: gpio register offsets are relatives to GPIOBASE

To: Phil Sutter <n0-1@freewrt.org>
Subject: Re: [PATCH] rb532: gpio register offsets are relatives to GPIOBASE
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 31 Oct 2008 14:47:06 +0000
Cc: linux-mips@linux-mips.org, Florian Fainelli <florian@openwrt.org>
In-reply-to: <1225459469-12279-1-git-send-email-n0-1@freewrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200810261112.37008.florian@openwrt.org> <1225459469-12279-1-git-send-email-n0-1@freewrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Oct 31, 2008 at 02:24:29PM +0100, Phil Sutter wrote:

> From: Florian Fainelli <florian@openwrt.org>
> 
> This patch fixes the wrong use of GPIO register offsets
> in devices.c. To avoid further problems, use gpio_get_value
> to return the NAND status instead of our own expanded code.
> 
> Also define the zero offset of the alternate function register to allow
> consistent access.
> 
> Signef-off-by: Phil Sutter <n0-1@freewrt.org>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>

Thanks, applied - with the SOBs fixed up.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>